[
https://issues.apache.org/jira/browse/SOLR-12393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913780#comment-16913780
]
David Smiley commented on SOLR-12393:
-------------------------------------
I reviewed the code but admittedly not the test. I don't think we should
examine {{groupExpandCollector.scoreMode()}} to determine if the scores are
already present. Instead, just look to see if the scores aren't already there
-- they will be NaN if not. This addresses the two comment lines you added
which can then be removed.
> ExpandComponent only calculates the score of expanded docs when sorted by
> score
> -------------------------------------------------------------------------------
>
> Key: SOLR-12393
> URL: https://issues.apache.org/jira/browse/SOLR-12393
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Reporter: David Smiley
> Priority: Major
> Attachments: SOLR-12393.patch, SOLR-12393.patch, SOLR-12393.patch
>
>
> If you use the ExpandComponent to show expanded docs and if you want the
> score back (specified in "fl"), it will be NaN if the expanded docs are
> sorted by anything other than the default score descending.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
