[ 
https://issues.apache.org/jira/browse/SOLR-13683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914714#comment-16914714
 ] 

Niranjan Nanda commented on SOLR-13683:
---------------------------------------

I am not sure; but I do not think you guys have decoupled yourself completely 
from Jetty. For example {{*_HttpListenerFactory_*}} uses the Jetty APIs. If you 
really want to abstract users of your APIs completely from underneath HTTP 
libraries, you should define your own abstraction for everything - connection 
pool size (may be type too), timeouts - everything globally applicable to HTTP. 

The API {{*_Http2SolrClient_*}} is not very clear in intent. It allows setting 
max connection per host, connection timeout - which are HTTP related, but not 
setting HTTP headers. Why is so?

 

 

> SolrJ 8.1.1 Http2SolrClient should allow customizing HTTP headers
> -----------------------------------------------------------------
>
>                 Key: SOLR-13683
>                 URL: https://issues.apache.org/jira/browse/SOLR-13683
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: clients - java
>    Affects Versions: 8.1.1
>            Reporter: Niranjan Nanda
>            Priority: Minor
>
> Currently {{Http2SolrClient}} does not allow configuring custom headers. For 
> example, how to pass Basic Auth headers? It should expose some builder APIs 
> to pass such headers.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to