iverase commented on a change in pull request #844: LUCENE-8860: Make more
decision on inner nodes in ShapeBoundingBoxQuery
URL: https://github.com/apache/lucene-solr/pull/844#discussion_r318499931
##########
File path: lucene/sandbox/src/java/org/apache/lucene/geo/Rectangle2D.java
##########
@@ -183,6 +191,33 @@ private static Relation compareBBoxToRangeBBox(final
byte[] bbox,
Arrays.compareUnsigned(maxTriangle, maxYOffset, maxYOffset + BYTES,
bbox, 2 * BYTES, 3 * BYTES) <= 0) {
return Relation.CELL_INSIDE_QUERY;
}
+
Review comment:
This first check can be skipped for intersects? maybe add it in an else
statement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
