atris edited a comment on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-525720523 @jimczi Updated the PR with implementation for `TopScoreDocsCollector`. Haven't added the corresponding `CollectorManager` yet though, I presume that can be done separately? Luceneutil numbers on the latest version: TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff MedSloppyPhrase 498.64 (6.9%) 484.94 (16.3%) -2.7% ( -24% - 21%) HighIntervalsOrdered 303.56 (10.5%) 296.03 (11.8%) -2.5% ( -22% - 22%) BrowseDateTaxoFacets 3366.36 (5.2%) 3328.48 (5.4%) -1.1% ( -11% - 9%) HighSloppyPhrase 500.45 (8.4%) 496.32 (9.1%) -0.8% ( -16% - 18%) IntNRQ 1108.56 (3.3%) 1104.31 (4.6%) -0.4% ( -7% - 7%) Fuzzy1 321.49 (4.8%) 320.92 (4.1%) -0.2% ( -8% - 9%) HighPhrase 571.71 (9.5%) 571.13 (8.8%) -0.1% ( -16% - 20%) Respell 386.71 (8.4%) 386.35 (8.1%) -0.1% ( -15% - 17%) AndHighHigh 807.05 (2.5%) 806.66 (4.2%) -0.0% ( -6% - 6%) HighTermDayOfYearSort 733.99 (4.4%) 733.77 (5.6%) -0.0% ( -9% - 10%) OrHighLow 1158.52 (1.7%) 1159.52 (3.6%) 0.1% ( -5% - 5%) BrowseDayOfYearTaxoFacets 8364.69 (2.9%) 8375.25 (2.8%) 0.1% ( -5% - 5%) BrowseMonthSSDVFacets 1999.10 (2.9%) 2005.14 (3.8%) 0.3% ( -6% - 7%) BrowseMonthTaxoFacets 8403.68 (2.5%) 8430.34 (3.5%) 0.3% ( -5% - 6%) MedTerm 3481.42 (3.0%) 3495.13 (3.0%) 0.4% ( -5% - 6%) MedPhrase 813.12 (4.0%) 816.40 (4.0%) 0.4% ( -7% - 8%) BrowseDayOfYearSSDVFacets 1762.24 (2.9%) 1770.51 (4.5%) 0.5% ( -6% - 8%) OrHighMed 408.00 (3.8%) 409.94 (4.7%) 0.5% ( -7% - 9%) PKLookup 148.60 (3.5%) 149.33 (6.3%) 0.5% ( -9% - 10%) HighTermMonthSort 1869.60 (12.7%) 1879.81 (13.1%) 0.5% ( -22% - 30%) Wildcard 898.93 (3.8%) 903.87 (3.7%) 0.5% ( -6% - 8%) HighTerm 2075.22 (3.2%) 2088.85 (2.9%) 0.7% ( -5% - 6%) LowPhrase 610.73 (4.6%) 617.56 (3.8%) 1.1% ( -6% - 9%) LowSloppyPhrase 825.44 (3.2%) 835.72 (3.3%) 1.2% ( -5% - 7%) LowSpanNear 1388.73 (2.2%) 1409.14 (2.8%) 1.5% ( -3% - 6%) AndHighLow 3047.72 (5.5%) 3096.11 (5.9%) 1.6% ( -9% - 13%) MedSpanNear 750.19 (2.9%) 763.02 (2.0%) 1.7% ( -3% - 6%) LowTerm 3670.47 (3.6%) 3736.25 (4.9%) 1.8% ( -6% - 10%) HighSpanNear 401.49 (5.4%) 408.94 (4.5%) 1.9% ( -7% - 12%) Prefix3 390.52 (9.0%) 397.98 (7.5%) 1.9% ( -13% - 20%) OrHighHigh 319.58 (15.3%) 326.27 (9.9%) 2.1% ( -20% - 32%) AndHighMed 1011.67 (3.5%) 1035.03 (3.8%) 2.3% ( -4% - 9%) Fuzzy2 37.75 (25.1%) 39.47 (24.4%) 4.6% ( -35% - 72%)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org