[ 
https://issues.apache.org/jira/browse/SOLR-9505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921662#comment-16921662
 ] 

Lucene/Solr QA commented on SOLR-9505:
--------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  6s{color} 
| {color:red} SOLR-9505 does not apply to master. Rebase required? Wrong 
Branch? See 
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for help. 
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-9505 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12828195/SOLR-9505.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/546/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Extra tests to confirm Atomic Update remove behaviour
> -----------------------------------------------------
>
>                 Key: SOLR-9505
>                 URL: https://issues.apache.org/jira/browse/SOLR-9505
>             Project: Solr
>          Issue Type: Test
>    Affects Versions: 7.0
>            Reporter: Tim Owen
>            Priority: Minor
>         Attachments: SOLR-9505.patch
>
>
> The behaviour of the Atomic Update {{remove}} operation in the code doesn't 
> match the description in the Confluence documentation, which has been 
> questioned already. From looking at the source code, and using curl to 
> confirm, the {{remove}} operation only removes the first occurrence of a 
> value from a multi-valued field, it does not remove all occurrences. The 
> {{removeregex}} operation does remove all, however.
> There are unit tests for Atomic Updates, but they didn't assert this 
> behaviour, so I've added some extra assertions to confirm that, and a couple 
> of extra tests including one that checks that {{removeregex}} does a Regex 
> match of the whole value, not just a find-anywhere operation.
> I think it's the documentation that needs clarifying - the code behaves as 
> expected (assuming {{remove}} was intended to work that way?)



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to