[
https://issues.apache.org/jira/browse/SOLR-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922987#comment-16922987
]
Erick Erickson commented on SOLR-13655:
---------------------------------------
{color:#000000}Yeah, it’s there. For certain idioms, running “precommit” will
catch them, specifically “var” declarations and a particular form of diamond
operator. It doesn’t check for much else, so this won’t fail precommit.{color}
And the regex that checks for “var” misses some usages, one I saw recently was
try (var blah blah blah) {
}
It’s not a hard rule though. The problem is it complicates back-porting 9.0 ->
8.x and the general consensus was that we should refrain from stuff that
complicated backports. See: SOLR-13658
And why the heck, when I follow a commit sha and click on the "diff" link for
any files that changed does it bive me a 403 "You don't have permission to
access this resource." error? Annoying.
> Cut Over Collections.unmodifiableSet usages to Set.*
> ----------------------------------------------------
>
> Key: SOLR-13655
> URL: https://issues.apache.org/jira/browse/SOLR-13655
> Project: Solr
> Issue Type: Improvement
> Reporter: Atri Sharma
> Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
