jpountz commented on a change in pull request #769: LUCENE-8905: Better Error
Handling For Illegal Arguments
URL: https://github.com/apache/lucene-solr/pull/769#discussion_r321098166
##########
File path: lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java
##########
@@ -137,12 +137,12 @@ public TopDocs topDocs(int start, int howMany) {
int size = topDocsSize();
- if (start < 0 || start > size) {
+ if (start < 0) {
Review comment:
I think we should still fail if start > howMany?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
