[ 
https://issues.apache.org/jira/browse/SOLR-13745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924690#comment-16924690
 ] 

Hoss Man commented on SOLR-13745:
---------------------------------

Interesting...

David: i suspect the reason these test bugs didn't manifest until after your 
commits in SOLR-13728 is because the new code you added in that issue causes 
DistributedUpdateProcessor to now call {{req.getSearcher().count(...)}} – 
resulting in {{SolrQueryRequestBase.searcherHolder}} getting populated in a way 
that it wouldn't have been previously for some of the {{LocalSolrQueryRequest}} 
instances used in this test.

As for why it didn't fail when you ran tests before committing SOLR-13728 ... 
i'm guessing that maybe this is because of SOLR-13747 / SOLR-12988 ?

(I've already confirmed SOLR-13746 is the reason [yetus's patch review build of 
SOLR-13728|https://builds.apache.org/job/PreCommit-SOLR-Build/543/testReport/] 
didn't catch this either)

> Test should close resources: AtomicUpdateProcessorFactoryTest 
> --------------------------------------------------------------
>
>                 Key: SOLR-13745
>                 URL: https://issues.apache.org/jira/browse/SOLR-13745
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 8.3
>
>
> This tests hangs after the test runs because there are directory or request 
> resources (not sure yet) that are not closed.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to