dsmiley commented on a change in pull request #855: SOLR-13739: Improve
performance on huge schema updates
URL: https://github.com/apache/lucene-solr/pull/855#discussion_r322209342
##########
File path: solr/core/src/java/org/apache/solr/rest/RestManager.java
##########
@@ -76,7 +76,7 @@
private static class ManagedResourceRegistration {
String resourceId;
Class<? extends ManagedResource> implClass;
- List<ManagedResourceObserver> observers = new ArrayList<>();
+ Set<ManagedResourceObserver> observers = new HashSet<>();
Review comment:
I propose using LinkedHashSet so that these get initialized in a consistent
predictable order. Ideally this doesn't matter but it can help in debugging
and in case some custom components are ordering dependent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
