mikemccand commented on a change in pull request #815: LUCENE-8213: Introduce
Asynchronous Caching in LRUQueryCache
URL: https://github.com/apache/lucene-solr/pull/815#discussion_r322809172
##########
File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
##########
@@ -726,14 +790,35 @@ public ScorerSupplier scorerSupplier(LeafReaderContext
context) throws IOExcepti
DocIdSet docIdSet;
try {
docIdSet = get(in.getQuery(), cacheHelper);
+ } catch (AsyncQueryLoadInProgressException e) {
Review comment:
We could alternatively have this request wait for cache to populate and then
return that cached result. It'd be cheaper CPU overall, especially in
degenerate queries where the same query is often executed multiple times
concurrently, but I think more complicated here, so let's go forward w/ this
approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
