KoenDG opened a new pull request #868: LUCENE-8975: Code Cleanup: Use entryset for map iteration wherever possible. URL: https://github.com/apache/lucene-solr/pull/868 https://issues.apache.org/jira/browse/LUCENE-8975 Some simple cleanup. No need to spend company/personal time reviewing this, would be good if someone had some spare time. If you don't, feel free to close this tab. It's a very simple PR: just changing `keySet()` to `entrySet()` **when possible**. In general just the better choice. Only really a performance gain when going over a TreeMap(as I recall at least), but in general a good idea to consistent with it. 2 exceptions where it gets changed to `values()`. All changes done automatically by Intellij. And 1 String construction in a loop that got turned into a Stringbuilder because that's just wasteful. That's over in solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java All tests have run locally and succeeded.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
