[
https://issues.apache.org/jira/browse/SOLR-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106707#comment-13106707
]
Robert Muir commented on SOLR-2754:
-----------------------------------
Thanks for the review David!
{quote}
LMDirichletSimilarity has a mu-less constructor. Maybe we could avoid defining
a constant in two places if we used that? E.g.
Same goes for H3 and Z.
{quote}
+1, I think it would be good (though probably unavoidable for e.g. BM25's (k1,
b) to do it this way if we want to provide default parameters.
Alternative, another idea would be for all 'parametric' models to require the
parameter? Then in the "still-to-be-written" test config
that tests all these sims, we would just have good default parameters
specified? Part of me likes this solution: if you are using a parametric
model then it requires you to think about it?
{quote}
Wouldn't it be good if we could instantiate custom classes via reflection?
{quote}
We could add this, e.g. if the parameter doesnt match any of the supplied
names. But i started thinking about this, say I created NormalizationRob,
and it wants a bunch of parameters... at the end of the day for practical
purposes a user could just make their own simple factory that uses
I(F)BRob(2.3, 4.5, 6.99) or whatever they wanted, because I think the intent
here is to support all of lucene-core's capabilities?
Its still pluggable in the sense someone can always make their own factory for
their custom stuff.
{quote}
I don't know the Lucene/Solr conventions for line length. There are some rather
long lines in IB and DFR, but maybe its not a problem?
{quote}
Yeah maybe especially for the javadocs, but we can probably re-arrange these.
> create Solr similarity factories for new ranking algorithms
> -----------------------------------------------------------
>
> Key: SOLR-2754
> URL: https://issues.apache.org/jira/browse/SOLR-2754
> Project: Solr
> Issue Type: New Feature
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: SOLR-2754.patch
>
>
> To make it easy to use some of the new ranking algorithms, we should add
> factories to solr:
> * for parametric models like LM and BM25 so that parameters can be set from
> schema.xml
> * for framework models like DFR and IB, so that different basic
> models/normalizations/lambdas can be chosen
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
