eribeiro commented on a change in pull request #864: SOLR-13101 : Shared 
storage support in SolrCloud
URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323967328
 
 

 ##########
 File path: 
solr/core/src/java/org/apache/solr/handler/admin/RequestApplyUpdatesOp.java
 ##########
 @@ -68,4 +74,20 @@ public void execute(CoreAdminHandler.CallInfo it) throws 
Exception {
       if (it.req != null) it.req.close();
     }
   }
+
+
+  private void pushToSharedStore(SolrCore core) {
+    // Push the index to blob storage before we set our state to ACTIVE
+    CloudDescriptor cloudDesc = core.getCoreDescriptor().getCloudDescriptor();
+    if (cloudDesc.getReplicaType().equals(Replica.Type.SHARED)) {
 
 Review comment:
   `Replica.Type.SHARED` is a enum so this line could be as below, right?
   
   ```suggestion
       if (cloudDesc.getReplicaType() == Replica.Type.SHARED) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to