Let's continue on the PR in https://issues.apache.org/jira/browse/LUCENE-8986 I just added your suggestion to the PR https://github.com/apache/lucene-solr/pull/958
-- Jan Høydahl, search solution architect Cominvent AS - www.cominvent.com > 25. okt. 2019 kl. 19:09 skrev David Smiley <[email protected]>: > > I've found that it's rather rare that PRs have been carefully crafted such > that rebase is appropriate. All commit messages prefixed and subjectively > not "too many" commits either. BTW remember this is just for the GitHub UI; > at the CLI you can do whatever merge/rebase/squash commits you please. > > ~ David Smiley > Apache Lucene/Solr Search Developer > http://www.linkedin.com/in/davidwsmiley > <http://www.linkedin.com/in/davidwsmiley> > > On Fri, Oct 25, 2019 at 1:03 PM Michael Sokolov <[email protected] > <mailto:[email protected]>> wrote: > Looks good except are we sure we do not want rebase? > > On Fri, Oct 25, 2019, 5:51 PM David Smiley <[email protected] > <mailto:[email protected]>> wrote: > Infra informed me this is now self-service via adding a ".asf.yaml" file. I > looked a the docs and I see this is also an opportunity to set the GitHub > project's description, homepage link, and labels. I propose the following: > > # > https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories > > <https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories> > > github: > > description: "Search technology -- Apache Lucene and Apache Solr" > homepage: https://lucene.apache.org <https://lucene.apache.org/> > label: > - search-engine > - information-retrieval > > enabled_merge_buttons: > squash: true > merge: false > rebase: false
