The license .sha file was already updated, the right version just wasn’t in that build.gradle. Sorry again for the added noise, merging is messy ;-).
Cassandra On Nov 13, 2019, 7:47 AM -0600, Cassandra Targett <[email protected]>, wrote: > Yes, Erick, that was the cause of the problem Dawid noticed - I just pushed a > change to fix it before I saw your mail. I might need to fix the licenses on > that branch, but I’ll check that now too. > > I’ll confess I don’t think I re-ran the bareBonesHtmlValidation task after > I’d made other changes to the Jekyll version, so my fault, sorry for the > confusion. > > Cassandra > On Nov 13, 2019, 7:45 AM -0600, Erick Erickson <[email protected]>, > wrote: > > Dawid and Cassandra: > > > > In the gradle_8 checkout the versions.props file has: > > > > org.asciidoctor:asciidoctorj=1.6.0-alpha.5 > > > > which makes me nervous, so I changed to > > org.asciidoctor:asciidoctorj=1.6.2 > > > > in my local checkout. This may be the root of my issues for all I know. > > > > Cassandra: this may be relevant to your chasing this down > > > > Dawid: Let me try things fresh and we’ll go from there. My changes to the > > gradle_8 branch are all about trying to get the dependency versions in > > versions.props to match those in ivy-versions.properties since they’re > > lagging. Which means changing all the checksum files which.. This cured the > > odd problem if me not being able to switch between gradle and ant builds > > successfully. > > > > WDYT about just checking this in to the gradle_8 branch so we can all > > iterate from the same base? Who knows? Maybe whatever makes me “special” > > will be obvious. > > > > Oh, and now you know why people don’t trust me to make hardware changes ;) > > > > > > > > > On Nov 13, 2019, at 8:29 AM, Cassandra Targett <[email protected]> > > > wrote: > > > > > > I’ll look into it now. > > > > > > Cassandra > > > On Nov 12, 2019, 4:09 PM -0600, Dawid Weiss <[email protected]>, > > > wrote: > > > > Hi Cassandra, > > > > > > > > I fixed relative links issue (on jira/SOLR-13452_gradle_8) but there's > > > > still something odd with asciidoctor -- while the html site generation > > > > is fine now the validation isn't: > > > > > > > > .\gradlew -p solr\solr-ref-guide bareBonesHtmlValidation > > > > > > > > it's the same problem as before -- fails on two links with the section > > > > separator ("-"). I think it's the asciidoctor version problem (like > > > > before) so maybe we need to upgrade buildScript/ compile dependency > > > > from 1.6.0-alpha.5 to something else? > > > > > > > > Dawid > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > >
