Can you file a pull request to remove it? I added it initially hoping it'd help with test browsing but it's not going to work anyway (because Solr emits half a gig of logs).
Dawid On Wed, Jan 8, 2020 at 4:51 PM Thomas Matthijs <li...@selckin.be> wrote: > > Can reproduce your problem with java 13, so guess only 11 is currently > supported > > The buildscan plugin seems to be a problem > > https://github.com/apache/lucene-solr/blob/gradle-master/gradle/ci/buildscan.gradle > https://docs.gradle.com/enterprise/gradle-plugin/#connecting_to_scans_gradle_com > > ==> "Be careful not to commit agreement to the terms of service into a > project that may be built by others." > > Looks like its only for CI builds (?) build should probably be > disabled by default > > Builds seems to work with java 13 & gradle 6 with it removed: > > diff --git a/build.gradle b/build.gradle > index 8e90409dde7..428d7b3e93c 100644 > --- a/build.gradle > +++ b/build.gradle > @@ -1,10 +1,9 @@ > > plugins { > id "base" > id "com.palantir.consistent-versions" version "1.13.1" > - id "com.gradle.build-scan" version "3.0" > id 'de.thetaphi.forbiddenapis' version '2.7' apply false > } > > // Project version and main properties. Applies to all projects. > allprojects { > @@ -17,13 +16,10 @@ allprojects { > // if the build file is incorrectly written and evaluates something > // eagerly). > > apply from: file('gradle/generate-defaults.gradle') > > -// CI systems. > -apply from: file('gradle/ci/buildscan.gradle') > - > // Set up defaults and configure aspects for certain modules or functionality > // (java, tests) > apply from: file('gradle/defaults.gradle') > apply from: file('gradle/defaults-java.gradle') > apply from: file('gradle/testing/defaults-tests.gradle') > diff --git a/gradle/validation/check-environment.gradle > b/gradle/validation/check-environment.gradle > index 3acfbb306d2..1d2d6e5509f 100644 > --- a/gradle/validation/check-environment.gradle > +++ b/gradle/validation/check-environment.gradle > @@ -3,11 +3,11 @@ > > import org.gradle.util.GradleVersion > > configure(rootProject) { > ext { > - expectedGradleVersion = '5.6.4' > + expectedGradleVersion = '6.0.1' > expectedJavaVersion = JavaVersion.VERSION_11 > } > > wrapper { > distributionType = Wrapper.DistributionType.ALL > diff --git a/gradle/wrapper/gradle-wrapper.properties > b/gradle/wrapper/gradle-wrapper.properties > index 0ebb3108e20..1ba7206f882 100644 > --- a/gradle/wrapper/gradle-wrapper.properties > +++ b/gradle/wrapper/gradle-wrapper.properties > @@ -1,5 +1,5 @@ > distributionBase=GRADLE_USER_HOME > distributionPath=wrapper/dists > -distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-all.zip > +distributionUrl=https\://services.gradle.org/distributions/gradle-6.0.1-all.zip > zipStoreBase=GRADLE_USER_HOME > zipStorePath=wrapper/dists > > On Wed, 8 Jan 2020 at 16:38, Robert Muir <rcm...@gmail.com> wrote: > > > > right, that file is the exact one i change. the problem is if i change it > > to 6.0.1, then it wants me to buy something. > > > > On Wed, Jan 8, 2020 at 10:08 AM Thomas Matthijs <li...@selckin.be> wrote: > >> > >> ./gradlew should try to use gradle 5.6.4 see > >> ./gradle/wrapper/gradle-wrapper.properties > >> With java 11 this all builds fine for me (can export JAVA_HOME to change) > >> Which version of java are you using? the linked issue hints at java 13? > >> > >> On Wed, 8 Jan 2020 at 16:01, Robert Muir <rcm...@gmail.com> wrote: > >> > > >> > Here is the issue: https://github.com/gradle/gradle/issues/8681 > >> > > >> > I tried upgrading gradle to 6.0.1, but it seems now it wants me to buy > >> > something? > >> > > >> > ]$ ./gradlew help > >> > Starting a Gradle Daemon (subsequent builds will be faster) > >> > > >> > FAILURE: Build failed with an exception. > >> > > >> > * Where: > >> > Build file '/Users/rob.muir/eclipse.workspace/lucene-solr/build.gradle' > >> > line: 5 > >> > > >> > * What went wrong: > >> > An exception occurred applying plugin request [id: > >> > 'com.gradle.build-scan', version: '3.0'] > >> > > Failed to apply plugin [id 'com.gradle.build-scan'] > >> > > This build scan plugin is not compatible with less than Gradle 6.0. > >> > Please use the Gradle Enterprise plugin instead. > >> > > >> > On Wed, Jan 8, 2020 at 9:41 AM Robert Muir <rcm...@gmail.com> wrote: > >> >> > >> >> I tried it out just to see, here was my experience: > >> >> > >> >> $ git checkout gradle-master > >> >> Switched to branch 'gradle-master' > >> >> Your branch is up to date with 'origin/gradle-master'. > >> >> $ ./gradlew help > >> >> Starting a Gradle Daemon (subsequent builds will be faster) > >> >> > >> >> FAILURE: Build failed with an exception. > >> >> > >> >> * Where: > >> >> Settings file > >> >> '/Users/rob.muir/eclipse.workspace/lucene-solr/settings.gradle' > >> >> > >> >> * What went wrong: > >> >> Could not compile settings file > >> >> '/Users/rob.muir/eclipse.workspace/lucene-solr/settings.gradle'. > >> >> > startup failed: > >> >> General error during semantic analysis: Unsupported class file major > >> >> version 57 > >> >> > >> >> java.lang.IllegalArgumentException: Unsupported class file major > >> >> version 57 > >> >> at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:184) > >> >> at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:166) > >> >> at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:152) > >> >> at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:273) > >> >> at > >> >> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:81) > >> >> at > >> >> org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254) > >> >> at > >> >> org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192) > >> >> > >> >> On Wed, Jan 8, 2020 at 9:30 AM Dawid Weiss <dawid.we...@gmail.com> > >> >> wrote: > >> >>> > >> >>> I think the gradle-master branch is already workable enough to land on > >> >>> master. > >> >>> > >> >>> If you're not familiar with gradle then, once merged, run "gradlew > >> >>> help". > >> >>> > >> >>> Some notes. > >> >>> > >> >>> 1) I have been running tests on Windows and Linux, they're ok. The > >> >>> output is slightly different from ANT's but I think it's fine for > >> >>> working. > >> >>> > >> >>> 2) The speed of compilation and running tests selectively is much > >> >>> better than ant's, especially on multicore machines. > >> >>> > >> >>> 3) I use IntelliJ idea and the project imports into the IDE without > >> >>> any special handling. Code formatting and such may need to be adjusted > >> >>> though. > >> >>> > >> >>> 4) Some things are incomplete (precommit does a subset of checks). > >> >>> Some are missing (regeneration tasks). Some are different (handling of > >> >>> dependencies, build output folder locations). It will take some time > >> >>> and learning to live with a new build system. I tried to provide short > >> >>> guides into selective areas (they're available as help tasks or plain > >> >>> text files under help/). > >> >>> > >> >>> 5) If something does *not* work, let me know. > >> >>> > >> >>> 6) It'd be nice if we had a build job somewhere on a faster machine > >> >>> that would run at least "gradlew precommit check -x test" so that > >> >>> rudimentary checks are applied, without running all the tests. This > >> >>> would ensure consistency in dependencies, for example. > >> >>> > >> >>> 7) The parallel branch (gradle-master) and issue (LUCENE-9077) will be > >> >>> kept open and occasionally merged back and forth. > >> >>> > >> >>> I have to shift more focus to my daily job but will help out and chip > >> >>> at the remaining bits, time permitting. > >> >>> > >> >>> Dawid > >> >>> > >> >>> --------------------------------------------------------------------- > >> >>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > >> >>> For additional commands, e-mail: dev-h...@lucene.apache.org > >> >>> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > >> For additional commands, e-mail: dev-h...@lucene.apache.org > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
