I'm in favor of this approach mainly because of the line mentioned in the
Test Plan:

> If we move servlet initialization into Java code and get rid of web.xml,
we may be able to start Solr in the same way both in tests and in real life!

I feel that this should be a top level goal, along with taking another look
at EmbeddedSolrServer (perhaps it moves out of SolrJ?). Right now, I feel
like we effectively have no testing of the configurations that go into the
various xml files - can't speak for others, but it made me reluctant to
make changes to them.


Mike

On Tue, Mar 24, 2020 at 6:36 PM Jan Høydahl <jan....@cominvent.com> wrote:

> This SIP has changed name to SIP-6 and I have changed the email subject of
> this thread, please keep this new subject going forward.
> New SIP link:
> https://cwiki.apache.org/confluence/display/SOLR/SIP-6+Solr+should+own+the+bootstrap+process
>
> Jan
>
> 24. mar. 2020 kl. 22:48 skrev Uwe Schindler <u...@thetaphi.de>:
>
> Of course it's a single jvm. It's only a replacement for start.jar. the
> mock-up is already there.
>
> Uwe
>
> Am March 24, 2020 9:45:33 PM UTC schrieb Bram Van Dam <
> bram.van...@intix.eu>:
>>
>> On 24/03/2020 16:01, Jan Høydahl wrote:
>>
>>> It has been proposed many times to make Solr a truly standalone app and 
>>> that we should start Jetty from within Solr and not the other way around :)
>>>
>>
>> Do you see this running in a single JVM, i.e. you run solr.jar and it
>> then starts an embedded Jetty server? Or would solr.jar exec a new Java
>> process and take it from there?
>>
>> If it's all in one JVM, then the startup scripts probably won't be all
>> that different. Memory settings, OOM killers etc will still have to be
>> set up before using startup shellscripts and whatnot. If it's just a
>> small bootstrap jar which execs another JVM, a lot of the complicated
>> shell foo could probably be simplified.
>>
>>  - Bram
>> ------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org 
>> <dev-unsubscr...@lucene.apache.org>
>> For additional commands, e-mail: dev-h...@lucene.apache.org 
>> <dev-h...@lucene.apache.org>
>>
>>
> --
> Uwe Schindler
> Achterdiek 19, 28357 Bremen
> https://www.thetaphi.de
>
>
>

Reply via email to