Which target are you proposing to have fail? precommit seems like the right place to me ..
On Thu, Jun 18, 2020 at 3:49 PM Erick Erickson (Jira) <[email protected]> wrote: > > Erick Erickson created LUCENE-9411: > -------------------------------------- > > Summary: Fail complation on warnings > Key: LUCENE-9411 > URL: https://issues.apache.org/jira/browse/LUCENE-9411 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build > Reporter: Erick Erickson > Assignee: Erick Erickson > > > Moving this over here from SOLR-11973 since it's part of the build system and > affects Lucene as well as Solr. You might want to see the discussion there. > > We have a clean compile for both Solr and Lucene, no rawtypes, unchecked, > try, etc. warnings. There are some peculiar warnings (things like > SuppressFBWarnings, i.e. FindBugs) that I'm not sure about at all, but let's > assume those are not a problem. Now I'd like to start failing the compilation > if people write new code that generates warnings. > > From what I can tell, just adding the flag is easy in both the Gradle and Ant > builds. I still have to prove out that adding -Werrors does what I expect, > i.e. succeeds now and fails when I introduce warnings. > > But let's assume that works. Are there objections to this idea generally? I > hope to have some data by next Monday. > > FWIW, the Lucene code base had far fewer issues than Solr, but > common-build.xml is in Lucene. > > > > > > -- > This message was sent by Atlassian Jira > (v8.3.4#803005) > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
