On Tue, Oct 6, 2020 at 10:45 PM Anshum Gupta <[email protected]> wrote:
> > I haven’t looked at the current ref branch recently, but the folks who > have looked at it, if you think that this code can be merged into master > even as big chunks, that’d be the most confidence building way forward. > > +1 for considering this approach. merge up master into the branch, and make a big-ass PR to merge back. let people help review (maybe improve) the change as a whole. It's just a big PR, some huge ones like this have been done in lucene before too, unofficially called "unfuck" branches (sorry if you are offended at my terminology). Sometimes you just fix, refactor, cleanup, and keep iterating and see where it can lead. sometimes you revert a bunch of commits because you followed the wrong rabbit-hole, etc. Sometimes it may seem inconvenient, but I think we can all agree It's important to have folks that want to not just take the small fix, but see where it can go and make the whole thing better. Remember Mike's flexible indexing branch? So why not try this way, look at actual code changes and try to get into the master branch? Of course Uwe is willing to point build resources at it either way, but if you want to maximize testing, start with the devs and everyone's jenkins first before throwing at users. Master branch will get you more testing, for sure.
