Hi Marcus, PortSolr3Test is documented "Based off of Solr 3's SpatialFilterTest". Why do you propose removing it? A quick gloss over it suggests to me this test is a rather straight-forward test to understand and maintain, and should be fast. Perhaps the class name should have been something else, and consider it's heritage as an implementation detail that is only worthy of a comment? But then name it what? IMO it's fine.
TestGeo3dShapeWGS84ModelRectRelation: What about it? This test class is 99% implemented by it's subclass -- ShapeRectRelationTestCase. The subclass provides the Geo3d context to its superclass, and the rest is handled from there. The tests explicitly on this subclass are for some regressions. > Is there anyone keeping a list of test cases that we can get rid of or significantly refactor today? For Solr -- yes (sorta): SOLR-11872 <https://issues.apache.org/jira/browse/SOLR-11872>. That would be a major make-over, but wouldn't really change the number of tests; it'd make them easier to maintain and more flexible. There is another issue, SOLR-10229, pertaining to Solr tests ought to configure Solr themselves and rely less on static test config files, which are a mess to maintain. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Sun, Nov 1, 2020 at 5:21 PM Marcus Eagan <[email protected]> wrote: > Hi Community, > > Lately I have been reading a lot of test files in an attempt to understand > what they seek to accomplish. Specifically, what stability and reliability > assurance does a given test class provide. In short, I have found some test > files that I am unsure are required to provide any of the expected > guarantees of the project today. > > It is more possible that I am misreading or don’t know all the history to > opine, and I don’t want to waste anyone’s time with a ticket without first > raising a discussion here. Below, I’ll include a few examples from Lucene. > As of today, I fully intend to step through many of the test files from > Solr as well for a related effort, but I started with Lucene because I have > ~800 more classes in Solr to review/modify/flag for review and because > there is a fast-changing reference impl out there. > > The first example is the PortSolr3Test class. It seems relevant because it > tests some currently relevant cases, but the name suggests that it might > not be. > > Another class I read that has lots of cruft that I don't really could use > some guidance one on is the TestGeo3dShapeWGS84ModelRectRelation class. > Is it possible there are lots of test classes that are no longer necessary > given changes over the versions. > > Is there anyone keeping a list of test cases that we can get rid of or > significantly refactor today? > > Please advise, > > Marcus > >
