OK, I’ll do it against master. We’d love to see it in an 8.x release, though.
This would protect against the major Solr outages we’ve had in the past
few years.

A question for someone who knows the Java metrics stuff better than I do:

Is it OK to use com.sun.management.OperatingSystemMXBean instead
of the java.lang.management version? getSystemCpuLoad() is only in the
former. The current code uses java.lang.management.OperatingSystemMXBean.

wunder
Walter Underwood
wun...@wunderwood.org
http://observer.wunderwood.org/  (my blog)

> On Jan 8, 2021, at 10:16 AM, David Smiley <dsmi...@apache.org> wrote:
> 
> Glad to see you contributing Walter!
> 
> Unless you know it only applies to 8x, you should branch against master.
> 
> ~ David Smiley
> Apache Lucene/Solr Search Developer
> http://www.linkedin.com/in/davidwsmiley 
> <http://www.linkedin.com/in/davidwsmiley>
> 
> On Thu, Jan 7, 2021 at 4:26 PM Walter Underwood <wun...@wunderwood.org 
> <mailto:wun...@wunderwood.org>> wrote:
> Starting work on this change. Should that be against branch_8x?
> 
> https://issues.apache.org/jira/browse/SOLR-15056 
> <https://issues.apache.org/jira/browse/SOLR-15056>
> 
> wunder
> Walter Underwood
> wun...@wunderwood.org <mailto:wun...@wunderwood.org>
> http://observer.wunderwood.org/ <http://observer.wunderwood.org/>  (my blog)
> 

Reply via email to