I agree with Noble that we shouldn't let those flakies hold up the release. It really sucks, but Solr wouldn't've gotten out a release in years if that was our bar.
FWIW though I disagree with his finer point that we shouldn't worry about autoscaling in particular because it's slated for removal in 9.0. We're not releasing 9.0, we're releasing 8.8. And there's likely to be an 8.8.1 or 8.9 at some point later. So there's definitely a "point in trying to fix" those failures, generally speaking. Jason On Thu, Jan 28, 2021 at 6:01 PM Noble Paul <noble.p...@gmail.com> wrote: > > I'm not sure why the tests fail. But, there is no point in trying to > fix them if that code is removed from master and we do not plan to > support them anyway > > On Fri, Jan 29, 2021 at 9:43 AM David Smiley <david.w.smi...@gmail.com> wrote: > > > > Ah; I see they appear to be 8x only. Any idea what the story is with them? > > Do you think it is just test flakiness or flakiness in Solr's related > > functionality? > > > > ~ David > > > > > > On Thu, Jan 28, 2021 at 5:36 PM Noble Paul <noble.p...@gmail.com> wrote: > >> > >> Both of those are gone for good @David Smiley I think we can safely > >> make them BadApples > >> > >> On Fri, Jan 29, 2021 at 9:07 AM David Smiley <dsmi...@apache.org> wrote: > >> > > >> > I ran it twice on my old-ish MacBook, and it failed each time on Solr > >> > tests that have a history of flakiness (as shown by Hossman's awesome > >> > fucit.org site) -- AutoscalingHistoryHandlerTest & TestWithCollection. > >> > Neither seed repeated. I'll pass on voting. > >> > > >> > ~ David Smiley > >> > Apache Lucene/Solr Search Developer > >> > http://www.linkedin.com/in/davidwsmiley > >> > > >> > > >> > On Thu, Jan 28, 2021 at 11:35 AM Cassandra Targett > >> > <casstarg...@gmail.com> wrote: > >> >> > >> >> I’ve updated the Ref Guide to remove the DRAFT status on 8.8 pages, so > >> >> that’s done. I’ll also take care of the next Ref Guide step to update > >> >> the website to show 8.8 as the latest. > >> >> On Jan 28, 2021, 9:59 AM -0600, Tomás Fernández Löbbe > >> >> <tomasflo...@gmail.com>, wrote: > >> >> > >> >> It’s 9 binding: Noble, Tim, me, Ignacio, Mike M, Namgyu, Atri, Anshum > >> >> and Mike S. > >> >> > >> >> 1 non-binding: Haoyu > >> >> > >> >> > >> >> On Thu, Jan 28, 2021 at 5:34 AM Michael Sokolov <msoko...@gmail.com> > >> >> wrote: > >> >>> > >> >>> SUCCESS! [0:58:25.213071] > >> >>> > >> >>> +1 better late than never? > >> >>> > >> >>> On Thu, Jan 28, 2021 at 8:04 AM Ishan Chattopadhyaya > >> >>> <ichattopadhy...@gmail.com> wrote: > >> >>> > > >> >>> > Thanks Noble! > >> >>> > > >> >>> > On Thu, 28 Jan, 2021, 4:24 pm Noble Paul, <noble.p...@gmail.com> > >> >>> > wrote: > >> >>> >> > >> >>> >> [+1] 9 (4 binding) > >> >>> >> > >> >>> >> [0] 0 > >> >>> >> > >> >>> >> [-1] 0 > >> >>> >> > >> >>> >> > >> >>> >> This vote has PASSED. > >> >>> >> > >> >>> >> I shall proceed with the rest of the release process > >> >>> >> > >> >>> >> On Thu, Jan 28, 2021 at 6:24 PM Anshum Gupta > >> >>> >> <ans...@anshumgupta.net> wrote: > >> >>> >> > > >> >>> >> > Thanks for handing the release, Noble! > >> >>> >> > > >> >>> >> > +1 (binding) > >> >>> >> > > >> >>> >> > SUCCESS! [0:56:12.016387] > >> >>> >> > > >> >>> >> > Ran the smoke tester, a demo app, and checked the change log. All > >> >>> >> > of that looks good. > >> >>> >> > > >> >>> >> > On Mon, Jan 25, 2021 at 2:22 AM Noble Paul <noble.p...@gmail.com> > >> >>> >> > wrote: > >> >>> >> >> > >> >>> >> >> Please vote for release candidate 2 for Lucene/Solr 8.8.0 > >> >>> >> >> > >> >>> >> >> The artifacts can be downloaded from: > >> >>> >> >> > >> >>> >> >> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.8.0-RC2-revb10659f0fc18b58b90929cfdadde94544d202c4a/ > >> >>> >> >> > >> >>> >> >> python3 -u dev-tools/scripts/smokeTestRelease.py \ > >> >>> >> >> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.8.0-RC2-revb10659f0fc18b58b90929cfdadde94544d202c4a/ > >> >>> >> >> > >> >>> >> >> > >> >>> >> >> > >> >>> >> >> The vote will be open for at least 72 hours > >> >>> >> >> > >> >>> >> >> [ ] +1 approve > >> >>> >> >> [ ] +0 no opinion > >> >>> >> >> [ ] -1 disapprove (and reason why) > >> >>> >> >> > >> >>> >> >> Here is my +1 > >> >>> >> >> -- > >> >>> >> >> ----------------------------------------------------- > >> >>> >> >> Noble Paul > >> >>> >> >> > >> >>> >> >> --------------------------------------------------------------------- > >> >>> >> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > >> >>> >> >> For additional commands, e-mail: dev-h...@lucene.apache.org > >> >>> >> >> > >> >>> >> > > >> >>> >> > > >> >>> >> > -- > >> >>> >> > Anshum Gupta > >> >>> >> > >> >>> >> > >> >>> >> > >> >>> >> -- > >> >>> >> ----------------------------------------------------- > >> >>> >> Noble Paul > >> >>> >> > >> >>> >> --------------------------------------------------------------------- > >> >>> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > >> >>> >> For additional commands, e-mail: dev-h...@lucene.apache.org > >> >>> >> > >> >>> > >> >>> --------------------------------------------------------------------- > >> >>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > >> >>> For additional commands, e-mail: dev-h...@lucene.apache.org > >> >>> > >> > >> > >> -- > >> ----------------------------------------------------- > >> Noble Paul > > > > -- > ----------------------------------------------------- > Noble Paul > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
