Aha it's broken independently of your PR. I'll try to fix it, sorry for the noise.
- Houston On Thu, Mar 4, 2021 at 1:48 PM Dawid Weiss <[email protected]> wrote: > Thanks. I might have broken something... but it seems unlikely. I > merely shuffled some things around - it should be an identical build. > > D. > > On Thu, Mar 4, 2021 at 7:45 PM Houston Putman <[email protected]> > wrote: > > > > It worked as of 10 days ago: > https://github.com/apache/lucene-solr/actions/workflows/docker-test.yml > > > > I created a test PR to see if it works based on master: > https://github.com/apache/lucene-solr/pull/2454 > > > > On Thu, Mar 4, 2021 at 1:39 PM Dawid Weiss <[email protected]> > wrote: > >> > >> Thanks Houston. Is this failure on the branch only (does it work on > master)? > >> > >> Dawid > >> > >> On Thu, Mar 4, 2021 at 6:48 PM Houston Putman <[email protected]> > wrote: > >> > > >> > I'm not sure why the docker github action is failing... I've tried it > locally and it works fine. I'll do some more investigation. > >> > > >> > On Thu, Mar 4, 2021 at 3:25 AM Dawid Weiss <[email protected]> > wrote: > >> >> > >> >> Hi folks, > >> >> > >> >> I'll need some help with some remaining tasks to make the transition > >> >> easier after the solr repo split. I've made some changes to allow > >> >> building just Solr or just Lucene on master -- > >> >> > >> >> https://github.com/apache/lucene-solr/pull/2448 > >> >> > >> >> 1. I really don't know much about docker testing and why it fails on > that PR. > >> >> > >> >> 2. Lucene build seems to work just fine. > >> >> > >> >> 3. You can build Solr independently (with a Lucene snapshot from > >> >> Apache repository) by running: > >> >> > >> >> ./gradlew -Dskip.lucene=true assemble check -x test -x documentation > >> >> -x checkBrokenLinks -x checkLocalJavadocLinksSite > >> >> > >> >> the "-x" tasks are what I'll need some help with - I guess they do > >> >> have cross-references to Lucene-generated stuff that needs to be > >> >> replaced (or dropped). > >> >> > >> >> 4. There are three tests that need to be removed from the codebase, > >> >> moved to Lucene or rewritten: TestICUCollationField, > >> >> TestLuceneIndexBackCompat and TestXmlQParser. These tests require > >> >> access to Lucene test sources and these won't be published as an > >> >> artifact. > >> >> > >> >> An alternative to trying to solve the above is to just split the repo > >> >> and let it burn/ crash, but I thought by fixing those issues on > >> >> current master branch we can prepare the infrastructure while > >> >> everything else just works. > >> >> > >> >> Dawid > >> >> > >> >> --------------------------------------------------------------------- > >> >> To unsubscribe, e-mail: [email protected] > >> >> For additional commands, e-mail: [email protected] > >> >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
