Hi Greg, Since this is only a test patch, I think it is ok to merge this to branch_8_9 (if somebody thinks otherwise, please let us know). Please merge it, and I will try to build a release candidate after that.
On Sat, Jun 5, 2021 at 10:49 AM Greg Miller <[email protected]> wrote: > Hi Mayya- > > Thanks for writing this up! Yesterday we uncovered a test-case bug in > TestStringValueFacetCounts that can occasionally cause a randomized > test to fail (https://issues.apache.org/jira/browse/LUCENE-9991). I've > pushed a fix on lucene/main for this, but since this test-case (and > corresponding feature) is in the lucene-solr/branch_8_9 branch, it > would be good to include the fix there as well. > > I have a pretty limited understanding of how releases get cut, so I > wanted to make sure I'm following the right process for getting this > fix in place. I've just opened two PRs to backport this fix onto: > > 1. branch_8x: https://github.com/apache/lucene-solr/pull/2504 > 2. branch_8_9: https://github.com/apache/lucene-solr/pull/2505 > > Is this the correct process? Should I also reopen LUCENE-9991 and mark > it as an 8.9 "Blocker"? > > Thanks again! > > Cheers, > -Greg > > On Fri, Jun 4, 2021 at 11:24 AM Mayya Sharipova > <[email protected]> wrote: > > > > Please observe the normal rules: > > > > * No new features may be committed to the branch. > > * Documentation patches, build patches and serious bug fixes may be > > committed to the branch. However, you should submit all patches you > > want to commit to Jira first to give others the chance to review > > and possibly vote against the patch. Keep in mind that it is our > > main intention to keep the branch as stable as possible. > > * All patches that are intended for the branch should first be committed > > to the unstable branch, merged into the stable branch, and then into > > the current release branch. > > * Normal unstable and stable branch development may continue as usual. > > However, if you plan to commit a big change to the unstable branch > > while the branch feature freeze is in effect, think twice: can't the > > addition wait a couple more days? Merges of bug fixes into the branch > > may become more difficult. > > * Only Jira issues with Fix version 8.9 and priority "Blocker" will delay > > a release candidate build. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
