On Tue, Oct 26, 2021 at 8:01 PM Robert Muir <[email protected]> wrote: > > Hi Greg, I think the general issue is one of the API, the ValueSource > seems really geared at returning values from single-valued fields.
I think really, this is the core issue. This ValueSource thing was created before the days of docvalues, in a lot of cases will do inefficient things depending on how you hold it. I feel that things like facets apis should really try to move to lower-level apis (DoubleValuesSource, SortedSetDocValues, etc) Reverse the problem around from push to a pull, now if you want to give "computed field" or similar inputs to faceting (e.g. some kind of filtering-on-the-fly), you have the chance to implement it efficiently. The expressions module switched away from this ValueSource to a DoubleValues/DoubleValuesSource already, though I didn't follow specific reasons why. Maybe similar approaches apply to all the numerics. As far as the strings, personally, I'm not sure what a ValueSource API that "filters/transforms" terms should look like. Seems slow no matter how you do it. But maybe fresh ideas are needed. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
