[ 
https://issues.apache.org/jira/browse/LUCENE-3456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114221#comment-13114221
 ] 

Chris Male commented on LUCENE-3456:
------------------------------------

Sorting this out for the current codebase isn't a huge challenge.  I work from 
incrementToken() / reuseable/TokenStream() calls, and see whats being called in 
their vicinity.  But going forward, I agree using Mock* in Solr more makes 
sense.

> Analysis Consumers should end and close any TokenStreams
> --------------------------------------------------------
>
>                 Key: LUCENE-3456
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3456
>             Project: Lucene - Java
>          Issue Type: Sub-task
>            Reporter: Chris Male
>
> While converting consumers over to using reusableTokenStream, I notice many 
> don't call end() or close() on TokenStreams.
> Even if they are test TSs only created once, we should follow the defined 
> usage pattern.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to