Ah nvm I saw your later comment to the effect that we have a copy we can use already
On Fri, Feb 4, 2022, 8:57 AM GitBox <[email protected]> wrote: > > msokolov commented on pull request #641: > URL: https://github.com/apache/lucene/pull/641#issuecomment-1030007403 > > > I think we cannot use intinthashset in core since it's an external > dependency? Did it work for you though? > > On Thu, Feb 3, 2022, 1:36 PM Julie Tibshirani ***@***.***> > wrote: > > > Extracting HnswGraphSearcher is a lot nicer, I pushed that refactor. > > > > On the topic of hash sets, I tried switching to IntIntHashMap on top > of > > this PR and it gives a nice indexing speed-up. I can open a follow-up > PR. > > > > About reusing data structures across searches -- I've heard that some > > other HNSW implementations found this to be beneficial, specifically > > maintaining a shared pool of "visited" sets for searches to use. It > could > > indeed be complex though, I'd be curious to understand the the > magnitude of > > the improvement. > > > > — > > Reply to this email directly, view it on GitHub > > <https://github.com/apache/lucene/pull/641#issuecomment-1029284791>, > or > > unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AAHHUQJGMUPVH4ZEGND6IB3UZLDKNANCNFSM5NN57KCQ > > > > . > > Triage notifications on the go with GitHub Mobile for iOS > > < > https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 > > > > or Android > > < > https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub > >. > > > > You are receiving this because you commented.Message ID: > > ***@***.***> > > > > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > To unsubscribe, e-mail: [email protected] > > For queries about this service, please contact Infrastructure at: > [email protected] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
