> Yeah I agree: unit tests should strive to only and precisely fail for true > bugs, not false alarms like this. I'm sorry this failure wasted your time > Dawid!
Time's not wasted if we decide how to proceed on this. > So we should fix this failure somehow: Remove all too-big terms from all test > LineFileDocs sources (the small version in git and the large nightly > version)?; Switch this unit test to not use LineFileDocs?; Make this > exception a checked exception (not good to make all users pay the price of > the rare exception)? Change IndexWriter to silently drop these terms? I've seen people indexing weird files, even binary files - this exception does make sense to me - an insane input yields a sane response... I don't know what the right fix should be though. If we keep the current code as is then perhaps we can at least detect this particular type of exception and not fail the test? Alternatively, clean up the input data so that it doesn't have such enormous terms? D. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
