Ack, thanks Ignacio for the quick approval. Just merged the fix onto the 9.3 branch.
Cheers, -Greg On Thu, Jul 21, 2022 at 12:32 AM Ignacio Vera <iver...@gmail.com> wrote: > > Hi Greg, > > Yes please fix the test in branch 9.3, I have approved the PR. > > On Thu, Jul 21, 2022 at 12:08 AM Greg Miller <gsmil...@gmail.com> wrote: >> >> Thanks Ignacio! I just created >> https://issues.apache.org/jira/browse/LUCENE-10659 as a proposed >> blocker for 9.3. It's a small bug fix for a unit test I recently >> introduced on the 9x branch (one of the last things to get pulled into >> the 9.3 candidate). I think we ought to fix this test before cutting a >> 9.3 release. There's a PR associated with the issue already (the >> change is already patched into main/branch_9x). >> >> Cheers, >> -Greg >> >> On Wed, Jul 20, 2022 at 4:42 AM Ignacio Vera <iver...@gmail.com> wrote: >> > >> > Please find here the draft for the release highlights. I have probably >> > missed things that should be included so please feel free to add them. >> > >> > https://cwiki.apache.org/confluence/pages/resumedraft.action?draftId=217391905 >> > >> > On Wed, Jul 20, 2022 at 10:17 AM Ignacio Vera <iver...@gmail.com> wrote: >> >> >> >> NOTICE: >> >> >> >> >> >> Branch branch_9_3 has been cut and versions updated to 9.4 on stable >> >> branch. >> >> >> >> >> >> Please observe the normal rules: >> >> >> >> >> >> * No new features may be committed to the branch. >> >> >> >> * Documentation patches, build patches and serious bug fixes may be >> >> >> >> committed to the branch. However, you should submit all patches you >> >> >> >> want to commit to Jira first to give others the chance to review >> >> >> >> and possibly vote against the patch. Keep in mind that it is our >> >> >> >> main intention to keep the branch as stable as possible. >> >> >> >> * All patches that are intended for the branch should first be committed >> >> >> >> to the unstable branch, merged into the stable branch, and then into >> >> >> >> the current release branch. >> >> >> >> * Normal unstable and stable branch development may continue as usual. >> >> >> >> However, if you plan to commit a big change to the unstable branch >> >> >> >> while the branch feature freeze is in effect, think twice: can't the >> >> >> >> addition wait a couple more days? Merges of bug fixes into the branch >> >> >> >> may become more difficult. >> >> >> >> * Only Jira issues with Fix version 9.3 and priority "Blocker" will delay >> >> >> >> a release candidate build. >> >> >> >> >> >> >> >> The only step missing is to add the Jenkins job on the release branch >> >> which is something I don't really know how to do it, hopefully someone >> >> can help here. >> >> >> >> >> >> I am planning to build the first RC next Monday if there are no issues. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
