Thank you Anton for bringing closure! And Marc for catching this! Phew :)
Mike McCandless http://blog.mikemccandless.com On Thu, Apr 6, 2023 at 5:51 AM Anton Hägerstrand <an...@blunders.io> wrote: > Search profiling seems to work again - see e.g. > https://blunders.io/jfr-demo/searching-2023.04.04.18.03.12/jvm_info > > Thanks Marc for reporting and Mike for fixing! > > /Anton > > > On Tue, 4 Apr 2023, 17:53 Michael McCandless, <luc...@mikemccandless.com> > wrote: > >> Actually, I spoke too soon. The NIGHTLY_LOG_DIR is indeed a bit >> different -- this is where the nightly benchy writes/reads all past nightly >> results, generates charts from, etc. >> >> Mike McCandless >> >> http://blog.mikemccandless.com >> >> >> On Tue, Apr 4, 2023 at 11:50 AM Michael McCandless < >> luc...@mikemccandless.com> wrote: >> >>> On Tue, Apr 4, 2023 at 11:14 AM Anton Hägerstrand <an...@blunders.io> >>> wrote: >>> >>>> Thanks Mike - looks promising! I will have a look at the next upload. >>>> >>> >>> Yay. >>> >>> Out of curiosity - what is the reason for using >>>> constants.NIGHTLY_LOG_DIR instead of constants.LOGS_DIR, which seems to be >>>> what competition.py uses to write the files? Is it that they are always the >>>> same value for the nightly builds anyway? >>>> >>> >>> Hmm good question ;) It really should be constants.LOGS_DIR -- that is >>> indeed more general. I'll fix. (It is indeed the same value for nightly >>> benchy). >>> >>> Mike McCandless >>> >>> http://blog.mikemccandless.com >>> >>>>
