Hi,
the problem introduced by https://github.com/apache/lucene/pull/12754
was fixed. Sorry for this. On OpenJ9 the RAMUsageEstimator works correct
again:
2> Nov. 05, 2023 10:52:15 AM org.apache.lucene.util.HotspotVMOptions
<clinit>
2> *WARNUNG: Lucene cannot optimize algorithms or calculate object
sizes for JVMs that are not based on Hotspot or a compatible
implementation.*
1> JVM_IS_HOTSPOT_64BIT = false
1> COMPRESSED_REFS_ENABLED = false
1> NUM_BYTES_OBJECT_ALIGNMENT = 8
1> NUM_BYTES_OBJECT_REF = 8
1> NUM_BYTES_OBJECT_HEADER = 16
1> NUM_BYTES_ARRAY_HEADER = 24
1> LONG_SIZE = 24
2> NOTE: Windows 10 10.0 amd64/IBM Corporation 17.0.8.1
(64-bit)/cpus=1,threads=1,free=207903304,total=268435456
2> NOTE: All tests run in this JVM: [TestRamUsageEstimator]
:lucene:core:test (SUCCESS): 10 test(s), 1 skipped
The slowest suites (exceeding 1s) during this run:
2.70s TestRamUsageEstimator (:lucene:core)
Uwe
Am 05.11.2023 um 10:30 schrieb Uwe Schindler:
Hi,
this was my fault, as I had no J9 VM ready. The issue was moving the
Hotspot condition to the first if clause:
https://github.com/apache/lucene/pull/12754/files#diff-d66ace802ca787e308d675106db2413c4a77d36b51c5a2997bb7efdeeee49e8bR115
The test catched this - cool.
I will change the logic a bit to separate 64 bit detection from
Hotspot logic. The HotspotVMOptions.IS_HOTSPOT needs to go one line
down it is not needed for the logic, it needs to be just assigned to
the constant JVM_IS_HOTSPOT_64BIT.
Sorry fix is going out. Need to reactivate my J9 here to make sure all
is sane.
Uwe
Am 05.11.2023 um 10:16 schrieb Uwe Schindler:
I will look into this.
Could be related to the previous commit.
Uwe
Am 4. November 2023 16:17:45 MEZ schrieb Michael McCandless
<luc...@mikemccandless.com>:
Maybe J9 specific?
Mike McCandless
http://blog.mikemccandless.com
On Sat, Nov 4, 2023 at 11:01 AM Policeman Jenkins Server
<jenk...@thetaphi.de> wrote:
Build: https://jenkins.thetaphi.de/job/Lucene-main-Windows/13400/
Java: 64bit/openj9/jdk-17.0.5 -XX:-UseCompressedOops
-Xgcpolicy:gencon
2 tests failed.
FAILED:
org.apache.lucene.util.TestRamUsageEstimator.testReferenceSize
Error Message:
java.lang.AssertionError: For 64 bit JVMs, reference size
must be 8, unless compressed references are enabled
expected:<8> but was:<4>
Stack Trace:
java.lang.AssertionError: For 64 bit JVMs, reference size
must be 8, unless compressed references are enabled
expected:<8> but was:<4>
at
__randomizedtesting.SeedInfo.seed([41AB595A28A8656B:5D031209A44808B2]:0)
at app//org.junit.Assert.fail(Assert.java:89)
at app//org.junit.Assert.failNotEquals(Assert.java:835)
at app//org.junit.Assert.assertEquals(Assert.java:647)
at
app//org.apache.lucene.util.TestRamUsageEstimator.testReferenceSize(TestRamUsageEstimator.java:195)
at
java.base@17.0.5/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base@17.0.5/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at
java.base@17.0.5/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at
java.base@17.0.5/java.lang.reflect.Method.invoke(Method.java:568)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
at
app//org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
at
app//org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at
app//org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
at
app//org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at
app//org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at
app//org.junit.rules.RunRules.evaluate(RunRules.java:20)
at
app//com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
app//com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
at
app//com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
at
app//com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
at
app//org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at
app//com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
app//org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
at
app//com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at
app//com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at
app//com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
app//com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
app//org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at
app//org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at
app//org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at
app//org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at
app//org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
at
app//org.junit.rules.RunRules.evaluate(RunRules.java:20)
at
app//com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
app//com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
at
app//com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
at java.base@17.0.5/java.lang.Thread.run(Thread.java:857)
FAILED: org.apache.lucene.util.TestRamUsageEstimator.testQuery
Error Message:
java.lang.AssertionError: expected:<1160.0> but was:<1760.0>
Stack Trace:
java.lang.AssertionError: expected:<1160.0> but was:<1760.0>
at
__randomizedtesting.SeedInfo.seed([41AB595A28A8656B:CADA2D29D9225FBE]:0)
at app//org.junit.Assert.fail(Assert.java:89)
at app//org.junit.Assert.failNotEquals(Assert.java:835)
at app//org.junit.Assert.assertEquals(Assert.java:555)
at app//org.junit.Assert.assertEquals(Assert.java:685)
at
app//org.apache.lucene.util.TestRamUsageEstimator.testQuery(TestRamUsageEstimator.java:189)
at
java.base@17.0.5/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base@17.0.5/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at
java.base@17.0.5/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at
java.base@17.0.5/java.lang.reflect.Method.invoke(Method.java:568)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
at
app//org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
at
app//org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at
app//org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
at
app//org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at
app//org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at
app//org.junit.rules.RunRules.evaluate(RunRules.java:20)
at
app//com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
app//com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
at
app//com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
at
app//com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
at
app//com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
at
app//org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at
app//com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
app//org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
at
app//com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at
app//com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at
app//com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
app//com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
app//org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at
app//org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at
app//org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at
app//org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at
app//org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
at
app//org.junit.rules.RunRules.evaluate(RunRules.java:20)
at
app//com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
app//com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
at
app//com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
at java.base@17.0.5/java.lang.Thread.run(Thread.java:857)
---------------------------------------------------------------------
To unsubscribe, e-mail: builds-unsubscr...@lucene.apache.org
For additional commands, e-mail: builds-h...@lucene.apache.org
--
Uwe Schindler
Achterdiek 19, 28357 Bremen
https://www.thetaphi.de
--
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail:u...@thetaphi.de
--
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail:u...@thetaphi.de
