Yet another bug due to ghost fields. :( Thanks for fixing! For reference, I checked how postings work on SlowCompositeCodecReaderWrapper, since they are prone to ghost fields as well, and they seem to be ok.
I worry that it could actually occur in practice when enabling recursive graph bisection, so I would prefer to respin. On Thu, Nov 30, 2023 at 6:01 AM Luca Cavanna <l...@elastic.co.invalid> wrote: > SUCCESS! [0:33:10.432870] > > +1 > > On Thu, Nov 30, 2023 at 2:59 PM Chris Hegarty > <christopher.hega...@elastic.co.invalid> wrote: > >> Hi Mike, >> >> On 30 Nov 2023, at 11:41, Michael McCandless <luc...@mikemccandless.com> >> wrote: >> >> +1 to release. >> >> I hit a corner-case test failure and opened a PR to fix it: >> https://github.com/apache/lucene/pull/12859 >> >> >> Good find! It looks like the fix for this issue is well in hand - great. >> >> I don't think this should block the release? -- it looks exotic. >> >> >> I’m not sure how likely this bug is to show in real (non-test) scenarios, >> but it does look kinda “exotic” to me too. So unless there are counter >> arguments, I do not see it as critical, and therefore not needing a respin. >> >> -Chris. >> >> >> Thanks Chris! >> >> Mike McCandless >> >> http://blog.mikemccandless.com >> >> >> On Thu, Nov 30, 2023 at 1:16 AM Patrick Zhai <zhai7...@gmail.com> wrote: >> >>> SUCCESS! [1:03:54.880200] >>> >>> +1. Thank you Chris! >>> >>> On Wed, Nov 29, 2023 at 8:45 PM Nhat Nguyen >>> <nhat.ngu...@elastic.co.invalid> wrote: >>> >>>> SUCCESS! [1:11:30.037919] >>>> >>>> +1. Thanks, Chris! >>>> >>>> On Wed, Nov 29, 2023 at 8:53 AM Chris Hegarty >>>> <christopher.hega...@elastic.co.invalid> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please vote for release candidate 1 for Lucene 9.9.0 >>>>> >>>>> The artifacts can be downloaded from: >>>>> >>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.9.0-RC1-rev-92a5e5b02e0e083126c4122f2b7a02426c21a037 >>>>> >>>>> You can run the smoke tester directly with this command: >>>>> >>>>> python3 -u dev-tools/scripts/smokeTestRelease.py \ >>>>> >>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.9.0-RC1-rev-92a5e5b02e0e083126c4122f2b7a02426c21a037 >>>>> >>>>> The vote will be open for at least 72 hours, and given the weekend in >>>>> between, let’s it open until 2023-12-04 12:00 UTC. >>>>> >>>>> [ ] +1 approve >>>>> [ ] +0 no opinion >>>>> [ ] -1 disapprove (and reason why) >>>>> >>>>> Here is my +1 >>>>> >>>>> Draft release highlights can be viewed here (comments and feedback >>>>> welcome): >>>>> https://cwiki.apache.org/confluence/display/LUCENE/ReleaseNote9_9_0 >>>>> >>>>> -Chris. >>>>> >>>> >> -- Adrien
