Oh; I didn't know that took precedence -- makes sense. Hopefully a test subclass (like SolrTestCase) could override it as well.
On Mon, Feb 12, 2024 at 2:09 PM Dawid Weiss <dawid.we...@gmail.com> wrote: > > > You can override the defaults using sysprops in your CI builds - > > -Ptests.timeoutSuite=1000! > > takes precedence over any annotations (1 second). > > Dawid > > On Mon, Feb 12, 2024 at 7:53 PM David Smiley <dsmi...@apache.org> wrote: >> >> Looking at LuceneTestCase, I see the annotation from RandomizedTesting: >> @TimeoutSuite(millis = 2 * TimeUnits.HOUR) >> This matches my observations of some builds that timed out, perhaps >> some flaky test hanging in Solr (that extends LuceneTestCase). >> Looking at this annotation, there is further documentation that the >> default can be set via sysprop tests.timeoutSuite. Wouldn't doing >> that make more sense than hard-coding this figure in LuceneTestCase? >> For example, I'd like to have a normal/default test run have a low >> timeout (10min?) but on a "nightly" run on CI, use much higher. Not 2 >> hours though; individual tests needing so much should have a >> TimeoutSuite applied to them. >> >> ~ David Smiley >> Apache Lucene/Solr Search Developer >> http://www.linkedin.com/in/davidwsmiley >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
