I'll add a step in between 1 and 2 that I often forget: ./gradlew tidy This refactors your code to the style the project uses, which we have checks for.
On Sat, 25 May 2024 at 00:53, Michael Froh <msf...@gmail.com> wrote: > Is your new test uncommitted? > > The Gradle check will fail if you have uncommitted files, to avoid the > situation where it "works on my machine (because of a file that I forgot to > commit)". > > The rough workflow is: > > 1. Develop stuff (code and/or tests). > 2. Commit it. > 3. Gradle check. > 4. If Gradle check fails, then make changes and amend your commit. Go to 3. > > Hope that helps, > Froh > > > On Fri, May 24, 2024 at 3:31 PM Chang Hank <hackchang0...@gmail.com> > wrote: > >> After I added the new test case, I failed the ./gradlew check and it >> seems like the check failed because I added the new test case. >> Is there anything I need to do before executing ./gradlew check? >> >> Best, >> Hank >> >> > On May 24, 2024, at 12:53 PM, Chang Hank <hackchang0...@gmail.com> >> wrote: >> > >> > Hi Robert, >> > >> > Thanks for your advice, will look into it!! >> > >> > Best, >> > Hank >> >> On May 24, 2024, at 12:46 PM, Robert Muir <rcm...@gmail.com> wrote: >> >> >> >> On Fri, May 24, 2024 at 2:33 PM Chang Hank <hackchang0...@gmail.com> >> wrote: >> >>> >> >>> Hi all, >> >>> >> >>> I want to improve the code coverage for Lucene, which package would >> you recommend testing to do so? Do we need more coverage in the Core >> package? >> >>> >> >> >> >> Hello, >> >> >> >> I'd recommend looking at the help/tests.txt file, you can generate the >> >> coverage report easily and find untested code: >> >> >> >> https://github.com/apache/lucene/blob/main/help/tests.txt#L193 >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >> >> > >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >>
