See the PR, a subset is enough.
The problem with all classes comes from the fact that HPPC uses a
template mechanism (like NIO Buffer classes in JDK) to generate the
source code for all those combinations. We need to only fork all classes
we use. Actually we do not fork classes part of the HPPC repository, we
fork the output of the autogenerated code.
If we want to fork everything, I think we may need to better fork the
template engine and the templates :-)
Uwe
Am 27.05.2024 um 10:08 schrieb Chris Hegarty:
Hi,
+1 to moving the hppc fork to oal.internal.
+1
On 26 May 2024, at 13:33, Bruno Roustant <bruno.roust...@gmail.com> wrote:
Currently the hppc fork in Lucene is composed of 15 classes and 8 test classes.
Forking everything in hppc would mean 525 classes and 193 test classes. I'm not
sure we want to fork all hppc?
That sounds like quite a lot of classes. How much is actually necessary to
allow to remove the dependency? And/Or is there a place of natural place where
it makes logical sense to subset?
-Chris.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
--
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail: u...@thetaphi.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
