Problem already solved!
It was caused by this commit: https://github.com/apache/lucene/pull/12150
The problem is that the tasks for license checks have side-effects on
global properties, so they have to run. The above optimization added a
new output to one of the tasks, so it wan'st consistently executed.
Fix is here: https://github.com/apache/lucene/pull/13696
Uwe
Am 28.08.2024 um 18:27 schrieb Chris Hegarty:
On 28 Aug 2024, at 15:46, Michael McCandless <luc...@mikemccandless.com> wrote:
I opened https://github.com/apache/lucene/issues/13695 to try to get to the
bottom of this.
Thanks for opening this issue Mike. I’ve seen the warnings too, but have no
idea why they happen.
Only tangentially related, I wanna do a gradle bump (from 8.8 to 8.10), to get
better support for JDK 23, but ran into a couple of issues with how we define
properties - might be that we need a little tweaking in how we do this. Maybe a
gradle bump could fix the warnings, I dunno.
-Chris.
Mike McCandless
http://blog.mikemccandless.com
On Tue, Aug 27, 2024 at 4:29 PM Michael McCandless <luc...@mikemccandless.com>
wrote:
Hi Team,
When I run "gradle check" on main, sometimes I get seemingly false positive
warnings about dozens of unferenced license files, like this:
WARNING: there were unreferenced files under license folder:
- /s1/l/trunk/lucene/licenses/antlr4-runtime-LICENSE-BSD.txt
- /s1/l/trunk/lucene/licenses/antlr4-runtime-NOTICE.txt
- /s1/l/trunk/lucene/licenses/asm-LICENSE-BSD_LIKE.txt
- /s1/l/trunk/lucene/licenses/asm-NOTICE.txt
- /s1/l/trunk/lucene/licenses/asm-commons-LICENSE-BSD_LIKE.txt
- /s1/l/trunk/lucene/licenses/asm-commons-NOTICE.txt
- /s1/l/trunk/lucene/licenses/assertj-core-LICENSE-ASL.txt
- /s1/l/trunk/lucene/licenses/assertj-core-NOTICE.txt
- /s1/l/trunk/lucene/licenses/commons-codec-LICENSE-ASL.txt
- /s1/l/trunk/lucene/licenses/commons-codec-NOTICE.txt
...
If I then do a "./gradlew clean" and again "./gradlew check" the warnings seem to go
away, but then if I immediately run "./gradlew check" again (after clean then check), the warnings
return.
Does anyone know why this happens? Can we stop the false positives? God
forbid I someday actually introduce a true positive warning, I would never
notice :)
Mike McCandless
http://blog.mikemccandless.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
--
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail: u...@thetaphi.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
