SUCCESS! [1:37:01.495562] +1
-Chris. > On 16 Dec 2024, at 17:20, Michael Sokolov <msoko...@gmail.com> wrote: > > SUCCESS! [1:54:16.305613] > > +1 > > On Mon, Dec 16, 2024 at 4:32 AM Ignacio Vera <iver...@gmail.com> wrote: >> >> SUCCESS! [1:16:40.906176] >> >> +1 >> >> On Mon, Dec 16, 2024 at 9:05 AM Luca Cavanna <java...@apache.org> wrote: >>> >>> Ok, thanks for clarifying Jim, that means we go ahead with th RC1 vote, >>> unless there are objections. >>> >>> Cheers >>> Luca >>> >>> On Mon, Dec 16, 2024, 08:37 jim ferenczi <jim.feren...@gmail.com> wrote: >>>> >>>> Hi, >>>> Sorry for the mix-up, Adrien's comment reminded me how deletes work in >>>> block joins. So the PR is more of an "optimisation" and can wait for >>>> another release. >>>> >>>> On Sun, 15 Dec 2024 at 23:13, Marcus Eagan <marcusea...@gmail.com> wrote: >>>>> >>>>> The PR looks great! I also agree with the comment from Adrien at first >>>>> glance. I wield no binding vote and have no dog in the fight, except I >>>>> hope I didn’t introduce the “bug.” >>>>> >>>>> Marcus Eagan >>>>> >>>>> >>>>> >>>>> On Sun, Dec 15, 2024 at 09:20 Luca Cavanna <java...@apache.org> wrote: >>>>>> >>>>>> Hi Jim, >>>>>> Thanks for flagging this. >>>>>> >>>>>> Could you clarify what versions are affected by the bug you mentioned >>>>>> and when it was introduced? >>>>>> >>>>>> Thanks >>>>>> Luca >>>>>> >>>>>> On Sun, Dec 15, 2024, 10:18 jim ferenczi <jim.feren...@gmail.com> wrote: >>>>>>> >>>>>>> Hi Luca, >>>>>>> >>>>>>> We found a bug in the bulk scorer of the ToParentBlockJoinQuery where >>>>>>> deleted documents aren’t handled correctly. This causes deleted docs to >>>>>>> be collected when the scorer is used. >>>>>>> The issue was introduced in Lucene 9.12.0, and its impact is quite >>>>>>> significant. I’ve opened a fix here and would like to propose adding it >>>>>>> to the upcoming release since we already missed 9.12.1. >>>>>>> >>>>>>> Let me know what you think. >>>>>>> >>>>>>> Cheers, >>>>>>> Jim >>>>>>> >>>>>>> On Sat, 14 Dec 2024 at 23:00, Luca Cavanna <java...@apache.org> wrote: >>>>>>>> >>>>>>>> Please vote for release candidate 1 for Lucene 10.1.0 >>>>>>>> >>>>>>>> The artifacts can be downloaded from: >>>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.1.0-RC1-rev-6a0531b0f48a0e781a7f72e9639c5f94138118ea >>>>>>>> >>>>>>>> You can run the smoke tester directly with this command: >>>>>>>> >>>>>>>> python3 -u dev-tools/scripts/smokeTestRelease.py \ >>>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.1.0-RC1-rev-6a0531b0f48a0e781a7f72e9639c5f94138118ea >>>>>>>> >>>>>>>> The vote will be open for at least 72 hours i.e. until 2024-12-17 >>>>>>>> 23:00 UTC. >>>>>>>> >>>>>>>> [ ] +1 approve >>>>>>>> [ ] +0 no opinion >>>>>>>> [ ] -1 disapprove (and reason why) >>>>>>>> >>>>>>>> Here is my +1 >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
