Greg, Thanks for your review. All, beware I'm a little bit hesitant to push https://github.com/apache/lucene/pull/13974 into sandbox. Will do it this week. Your feedback is quite appreciated.
On Fri, Nov 29, 2024 at 8:37 PM Greg Miller <gsmil...@gmail.com> wrote: > Ah right OK. Apologies. I misread your original email in haste. What > you’re proposing makes sense to me know. I’ll try to make time to look at > your approach next week if nobody else beats me to it. Thanks for the > clarification! > > Cheers, > -Greg > > On Tue, Nov 26, 2024 at 11:40 Mikhail Khludnev <m...@apache.org> wrote: > >> Hello Greg. >> Thanks for your reply. MultiRangeQuery is where I started from. MRQ reads >> points values [1] and I need the same functionality for docValues. >> >> [1] >> https://github.com/apache/lucene/blob/d9aa525c9ea52740cfb0ba3f79d65833ad6167a8/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java#L293 >> >> On Tue, Nov 26, 2024 at 8:26 PM Greg Miller <gsmil...@gmail.com> wrote: >> >>> Hi Mikhail- >>> >>> Thanks for opening up a PR and looking into this! I wonder if the >>> existing MultiRangeQuery[1] (and its sub-classes) in the sandbox module is >>> already a fit for what you're trying to do? Full disclosure: I haven't >>> looked at your proposed PR yet, so maybe you're after something entirely >>> different (apologies if so). >>> >>> Cheers, >>> -Greg >>> >>> [1] >>> https://github.com/apache/lucene/blob/main/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java >>> >>> On Thu, Nov 21, 2024 at 12:35 PM Mikhail Khludnev <m...@apache.org> >>> wrote: >>> >>>> Hello, >>>> I'm looking for MultiRangeQuery analog for docValues field. Let's say >>>> SortedSetDocValues. >>>> I made the first shot https://github.com/apache/lucene/pull/13974. >>>> Is it the right direction overall? Is it worth being committed into >>>> sandbox? >>>> Reviews are kindly welcome. Thanks! >>>> >>>> -- >>>> Sincerely yours >>>> Mikhail Khludnev >>>> >>> >> >> -- >> Sincerely yours >> Mikhail Khludnev >> > -- Sincerely yours Mikhail Khludnev
