Thank you for fixing this. I think there is a more systemic problem though? It looks like these don't cause HTTP 404s anymore, so checkJavadocLinks.py can't detect such broken references anymore? Yet doclint just lets them slip through? We may need to improve checkJavadocLinks.py to detect this new "invalid reference" case. Looking at the resulting HTML and dom, you get a "details" tag in this case with class "invalid-tag", with child "summary" tag containing "invalid reference", so we should be able to fail on it. I will open an issue.
On Fri, Jan 17, 2025 at 6:40 AM Dawid Weiss <dawid.we...@gmail.com> wrote: > > > Done. Thanks. > > On Fri, Jan 17, 2025 at 12:19 PM Mikhail Khludnev <m...@apache.org> wrote: >> >> Hello Dev. You are welcome to review an opportunistic fix for the red >> rectangles in javadoc. >> >> >> ---------- Forwarded message --------- >> From: github-actions[bot] <notificati...@github.com> >> Date: Wed, Jan 8, 2025 at 3:23 AM >> Subject: Re: [apache/lucene] javadocs: fix invalid refs in `queryparsers` >> #14086 (PR #14087) >> To: apache/lucene <luc...@noreply.github.com> >> Cc: Mikhail Khludnev <m...@apache.org>, Author <aut...@noreply.github.com> >> >> >> This PR has not had activity in the past 2 weeks, labeling it as stale. If >> the PR is waiting for review, notify the dev@lucene.apache.org list. Thank >> you for your contribution! >> >> — >> Reply to this email directly, view it on GitHub, or unsubscribe. >> You are receiving this because you authored the thread.Message ID: >> <apache/lucene/pull/14087/c2576470...@github.com> >> >> >> >> -- >> Sincerely yours >> Mikhail Khludnev --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
