+1 SUCCESS! [0:46:48.162090] I agree with not including changes to read advices in 10.2.1, it feels too big a change for inclusion in a patch release.
For reference, Ben also flagged this one as a candidate for 10.2.1: https://github.com/apache/lucene/pull/14543. I'm undecided on including it. On the one hand, it's been introduced in 10.0.0, on the other hand it causes trouble with things like IndexOrDocValuesQuery, which no longer make their decision on correct data, which could be quite impactful. On Thu, Apr 24, 2025 at 6:54 PM Chris Hegarty <christopher.hega...@elastic.co.invalid> wrote: > Hi Vigya, > > > Should we also revert the default ReadAdvice.RANDOM setting for 10.2.1 > release? > > I would prefer to not revert this in 10.2.1. The performance issue is not > new in 10.2, it was introduced in a prior release. The focus of 10.2.1 is > to address a couple of severe bugs are new in 10.2. > > Separately, we’re working on fixing the underlying issue in > https://github.com/apache/lucene/issues/14422, which will hopefully make > 10.3. > > -Chris. > > > On 24 Apr 2025, at 17:42, Vigya Sharma <vigya.w...@gmail.com> wrote: > > > > > > There are multiple reports (1, 2) of performance regressions after this > change. Issue #14408 has good context on the root cause: a patch in Linux > kernel stopped counting MADV_RANDOM accesses towards recency in the page > cache's LRU active/inactive list. The commit was in kernel 6.3 but some > have reported problems with 6.1 as well, (maybe some kernels backported the > patch?). I don't think this RC includes the revert yet. > > > > On Thu, Apr 24, 2025 at 9:06 AM Chris Hegarty > <christopher.hega...@elastic.co.invalid> wrote: > > Please vote for release candidate 1 for Lucene 10.2.1 > > > > The artifacts can be downloaded from: > > > https://dist.apache.org/repos/dist/dev/lucene/lucene-10.2.1-RC1-rev-02cf96b8f7c87fdf5eab864bfc242d36aa2086e7 > > > > You can run the smoke tester directly with this command: > > > > python3 -u dev-tools/scripts/smokeTestRelease.py \ > > > https://dist.apache.org/repos/dist/dev/lucene/lucene-10.2.1-RC1-rev-02cf96b8f7c87fdf5eab864bfc242d36aa2086e7 > > > > The vote will be open for at least 72 hours (excluding weekends) i.e. > until 2025-04-29 17:00 UTC. > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > Here is my +1 > > > > Draft release notes: > https://cwiki.apache.org/confluence/display/LUCENE/ReleaseNote10_2_1 > > > > -Chris. > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > > For additional commands, e-mail: dev-h...@lucene.apache.org > > > > > > > > -- > > - Vigya > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > > -- Adrien
