https://github.com/apache/lucene/pull/14740
This is completely complementary to spotless, and if/whether the existing sources are already formatted. Editorconfig means that *without customizing my IDE*, I can go edit a file, perhaps do a refactoring like "inline" or add code causing an import to be added, and the IDE will automatically make the source compliant with the .editorconfig settings, which are in turn based on GJS / Spotless settings. For cases when a user forgets to run "tidy", there's a decent chance the source will be compliant already. On Thu, May 29, 2025 at 1:24 PM Dawid Weiss <dawid.we...@gmail.com> wrote: > > I think most of the code is currently formatted automatically anyway > (python, java, gradle) but if it helps anybody - why not. > > Dawid > > On Thu, May 29, 2025 at 7:09 PM David Smiley <dsmi...@apache.org> wrote: > >> This is an old thread but I agree on editorConfig. It's one dot-file to >> add to our repo, and there are plugins for IntelliJ, Eclipse, and VS Code. >> I'll throw up a PR. >> >> On Tue, Mar 13, 2018 at 1:16 AM Alex Ott <alex...@gmail.com> wrote: >> >>> What about using something like http://editorconfig.org/ to handle this? >>> >>> David Smiley at "Fri, 31 Mar 2017 03:00:51 +0000" wrote: >>> DS> bq. Let's make 'em uniform and argue later. >>> >>> DS> Agreed. I find it very annoying that the indentation on some of >>> them are internally inconsistent. >>> >>> DS> On Wed, Mar 29, 2017 at 7:19 PM Erick Erickson < >>> erickerick...@gmail.com> wrote: >>> >>> DS> I don't think we've ever really had a formal rule, certainly >>> not one >>> DS> that's been enforced. Personally I'd be satisfied with just >>> doing >>> DS> whatever IntelliJ or Eclipse are happy with. >>> DS> >>> DS> I did finally take time to look and you can make IntelliJ >>> recognize >>> DS> "managed-schema" as an XML file with settings>>editor>>file >>> types >>> DS> >>> DS> Let's make 'em uniform and argue later. >>> DS> >>> DS> Erick >>> DS> >>> DS> On Wed, Mar 29, 2017 at 4:10 PM, Alexandre Rafalovitch >>> DS> <arafa...@gmail.com> wrote: >>> >> I am redoing an example and realized I have no idea what the >>> >> formatting rules are. >>> >> >>> >> In the code, the WIKI says, we should use 2-spaces offset. >>> >> >>> >> What about in config (XML) files? >>> >> >>> >> I see no tabs, so at least that part is clear. But with spaces, I see >>> >> all sorts of things. >>> >> >>> >> I seem to see a mix of 4 and 2 spaces in managed-schema. I seem to >>> see >>> >> 2 spaces in solrconfig.xml. I am not sure what I see in DIH >>> >> configuration files. >>> >> >>> >> Also, there are comments and their multi-line internal comments. I >>> >> seem to see 1 space there. Also, does the text in the comment start >>> on >>> >> the same line as comment indicator (<!---) or next line. Or >>> >> whatever.... ? >>> >> >>> >> Are there any resource or guideline on that? I am happy to apply a >>> >> style but not sure what that is. >>> >> >>> >> Regards, >>> >> Alex. >>> >> P.s. I guess managed-schema gets rewritten anyway, but - until then - >>> >> I want it to look pretty with all the comments right. >>> >> >>> >> ---- >>> >> http://www.solr-start.com/ - Resources for Solr users, new and >>> experienced >>> >> >>> >> --------------------------------------------------------------------- >>> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >>> >> For additional commands, e-mail: dev-h...@lucene.apache.org >>> >> >>> DS> >>> DS> >>> --------------------------------------------------------------------- >>> DS> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >>> DS> For additional commands, e-mail: dev-h...@lucene.apache.org >>> >>> >>> >>> -- >>> With best wishes, Alex Ott >>> http://alexott.net/ >>> Twitter: alexott_en (English), alexott (Russian) >>> >>
