Thank you for the clarification! On Tue, Jun 24, 2025 at 5:17 PM Michael Froh <msf...@gmail.com> wrote:
> Hi Akira, > > It was intentionally moved from DataInput in > https://github.com/apache/lucene/pull/13830 > > There's a whole story about it here: > https://github.com/apache/lucene/pull/13825 > > Hope that helps, > Froh > > On Tue, Jun 24, 2025 at 2:07 PM Akira Lonske <akiralon...@gmail.com> > wrote: > >> Hello! My name is Akira Lonske, and this summer I’ll be working as a SWE >> intern for Amazon's Lucene Search Team. I’m very grateful and excited for >> this opportunity to dive into the world of open source! >> >> For my first project, I have been assigned the implementation and testing >> of GroupVarInt encoding for HNSW Graphs. >> >> I had finished making edits to the Lucene99HnswVectorsWriter file, but >> when I started editing the Lucene99HnswVectorsReader file, I realized that >> I could not call the readGroupVInts method on IndexInput instances because >> that method is not written in DataInput, even though the writeGroupVInts >> methods are written in DataOutput. >> >> Is this asymmetry intentional, or simply an oversight? It seemed easy >> enough to write equivalent methods for DataInput that simply call the >> method in GroupVIntUtil, but perhaps I am missing something. Any >> clarification would be much appreciated. >> >> Thank you! >> Akira >> > --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >>
