[
https://issues.apache.org/jira/browse/LUCENE-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118142#comment-13118142
]
Robert Muir commented on LUCENE-3477:
-------------------------------------
Is it possible before committing to add some comments to explain the breaks?
e.g. instead of
{noformat}
-[^] { /* Not numeric, word, ideographic, hiragana, or SE Asian -- ignore it.
*/ }
+[^] { break; /* Not numeric, word, ideographic, hiragana, or SE Asian --
ignore it. */ }
{noformat}
maybe
{noformat}
-[^] { /* Not numeric, word, ideographic, hiragana, or SE Asian -- ignore it.
*/ }
+[^] { /* this break suppresses jflex warning: */ break; /* Not numeric, word,
ideographic, hiragana, or SE Asian -- ignore it. */ }
{noformat}
This way they don't get lost...
> Fix JFlex tokenizer compiler warnings
> -------------------------------------
>
> Key: LUCENE-3477
> URL: https://issues.apache.org/jira/browse/LUCENE-3477
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3477.patch
>
>
> We get lots of distracting fallthrough warnings running "ant compile"
> in modules/analysis, from the tokenizers generated from JFlex.
> Digging a bit, they actually do look spooky.
> So I managed to edit the JFlex inputs to insert a bunch of break
> statements in our rules, but I have no idea if this is
> right/dangerous, and it seems a bit weird having to do such insertions
> of "naked" breaks.
> But, this does fix all the warnings, and all tests pass...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
