[
https://issues.apache.org/jira/browse/LUCENE-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120386#comment-13120386
]
Shai Erera commented on LUCENE-3485:
------------------------------------
Patch looks good ! Few minor comments:
* I think that it's better to set closed=true in the end of doClose(), after
everything succeeds.
* In doClose, perhaps nullify the two caches? this can come instead of, or in
addition to, clear()-ing them
* doClose is package-private: is that on purpose, or did you mean to make it
protected/private? Seems to me like it should be private, because you don't
want to call it more than once.
> LuceneTaxonomyReader .decRef() may close the inner IR, renderring the LTR in
> a limbo.
> -------------------------------------------------------------------------------------
>
> Key: LUCENE-3485
> URL: https://issues.apache.org/jira/browse/LUCENE-3485
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/facet
> Affects Versions: 3.4
> Reporter: Gilad Barkai
> Priority: Minor
> Attachments: LUCENE-3485.patch
>
>
> TaxonomyReader which supports ref-counting, has a decRef() method which
> delegates to an inner IndexReader and calls its .decRef(). The latter may
> close the reader (if the ref is zeroes) but the taxonomy would remain 'open'
> which will fail many of its method calls.
> Also, the LTR's .close() method does not work in the same manner as
> IndexReader's - which calls decRef(), and leaves the real closing logic to
> the decRef(). I believe this should be the right approach for the fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
