[ 
https://issues.apache.org/jira/browse/LUCENE-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121077#comment-13121077
 ] 

Uwe Schindler commented on LUCENE-3489:
---------------------------------------

bq. (for example it's based on JUnit @Rules only, not on a custom runner/ base 
abstract class)

This is a nice idea, although the reason for the LuceneTestCaseRunner and the 
abstract base class is more because we hate @Test annotations and dont want to 
add thousands of stupid Assert-includes (having this is abstract base class is 
more convenient). Just to mention UweSays on twitter: 
[@UweSays|http://twitter.com/#!/UweSays]
                
> Refactor test classes that use assumeFalse(codec != SimpleText, Memory) to 
> use new annotation and move the expensive methods to separate classes
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3489
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3489
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: general/test
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>             Fix For: 4.0
>
>
> Folloup for LUCENE-3463.
> TODO:
> - Move test-methods that need the new @UseNoMemoryExpensiveCodec annotation 
> to separate classes
> - Eliminate the assumeFalse-calls that check the current codec and disable 
> the test if SimpleText or Memory is used

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to