[ 
https://issues.apache.org/jira/browse/LUCENE-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simon Willnauer updated LUCENE-3488:
------------------------------------

    Attachment: LUCENE-3488.patch

Thanks mike for fixing those issues and for the cleanups! I must have missed 
that sync on swapSearcher. Here is the next iteration, fixing all javadocs and 
removes the acquireLatest and release utilities from NRTManager. Users should 
really use the SM instead!

I think we are ready here!
                
> Factor out SearcherManager from NRTManager
> ------------------------------------------
>
>                 Key: LUCENE-3488
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3488
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.5, 4.0
>            Reporter: Simon Willnauer
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3488.patch, LUCENE-3488.patch, LUCENE-3488.patch
>
>
> Currently we have NRTManager and SearcherManager while NRTManager contains a 
> big piece of the code that is already in SearcherManager. Users are kind of 
> forced to use NRTManager if they want to have SearcherManager goodness with 
> NRT. The integration into NRTManager also forces you to maintain two 
> instances even if you know you always want deletes. To me NRTManager tries to 
> do more than necessary and mixes lots of responsibilities ie. handling 
> searchers and handling indexing generations. NRTManager should use a 
> SearcherManager by aggregation rather than duplicate a lot of logic. 
> SearcherManager should have a NRT and Directory based implementation users 
> can simply choose from.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to