[
https://issues.apache.org/jira/browse/LUCENE-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122580#comment-13122580
]
Doron Cohen commented on LUCENE-3262:
-------------------------------------
bq. changes entry
Right, I always forget to include it in the patch, and add it only afterwords,
should change that...
Also, I am not comfortable with the use of a config property in AddDocTask to
tell that facets should be added. Seems too implicit to me, all of the
sudden... So I think it would be better to refactor the doc creation in AddDoc
into a method, and add AddFacetedDocTask that extends AddDoc and overrides the
creation of the doc to be added, calling super, and then add the facets into it.
> Facet benchmarking
> ------------------
>
> Key: LUCENE-3262
> URL: https://issues.apache.org/jira/browse/LUCENE-3262
> Project: Lucene - Java
> Issue Type: New Feature
> Components: modules/benchmark, modules/facet
> Reporter: Shai Erera
> Assignee: Doron Cohen
> Attachments: CorpusGenerator.java, LUCENE-3262.patch,
> LUCENE-3262.patch, TestPerformanceHack.java
>
>
> A spin off from LUCENE-3079. We should define few benchmarks for faceting
> scenarios, so we can evaluate the new faceting module as well as any
> improvement we'd like to consider in the future (such as cutting over to
> docvalues, implement FST-based caches etc.).
> Toke attached a preliminary test case to LUCENE-3079, so I'll attach it here
> as a starting point.
> We've also done some preliminary job for extending Benchmark for faceting, so
> I'll attach it here as well.
> We should perhaps create a Wiki page where we clearly describe the benchmark
> scenarios, then include results of 'default settings' and 'optimized
> settings', or something like that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
