[
https://issues.apache.org/jira/browse/LUCENE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125989#comment-13125989
]
Simon Willnauer commented on LUCENE-3513:
-----------------------------------------
this makes sense though. I don't know to much about the highligher so I will
wait a day or so if nobody steps up I will take this issue.
> Add SimpleFragListBuilder constructor with margin parameter
> -----------------------------------------------------------
>
> Key: LUCENE-3513
> URL: https://issues.apache.org/jira/browse/LUCENE-3513
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/highlighter
> Affects Versions: 3.4
> Reporter: Kelsey Francis
> Priority: Minor
> Attachments: LUCENE-3513.patch
>
>
> {{SimpleFragListBuilder}} would benefit from an additional constructor that
> takes in {{margin}}. Currently, the margin is defined as a constant, so to
> "implement" a {{FragListBuilder}} with a different margin, one has no choice
> but to copy and paste {{SimpleFragListBuilder}} into a new class that must be
> placed in the {{org.apache.lucene.search.vectorhighlight}} package due to
> accesses of package-protected fields in other classes.
> If this change were made, the precondition check of the constructor's
> {{fragCharSize}} should probably be altered to ensure that it's less than
> {{max(1, margin*3)}} to allow for a margin of 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
