[
https://issues.apache.org/jira/browse/LUCENE-3512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125993#comment-13125993
]
Simon Willnauer commented on LUCENE-3512:
-----------------------------------------
that looks reasonable to me. some comments:
* can we rename public int getSeqnum() to something more useful? it seems
getPhraseNumber is better though?
* I wonder if we really need to expose the implementation rather than the
interface in public LinkedList<WeightedPhraseInfo> getPhraseList()? This should
return List<WeightedPhraseInfo> instead?
* would you mind adding one or two doc strings to those getters?
* while you are on it feel free to add more reasonable names etc. to that class
> Expose fields in FieldPhraseList and WeightedPhraseInfo with public getters
> ---------------------------------------------------------------------------
>
> Key: LUCENE-3512
> URL: https://issues.apache.org/jira/browse/LUCENE-3512
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/highlighter
> Affects Versions: 3.4
> Reporter: Kelsey Francis
> Priority: Minor
> Attachments: LUCENE-3512.patch
>
>
> Currently, to write a custom {{FragListBuilder}} implementation or custom
> highlighter, it probably will have to be placed in the
> {{org.apache.lucene.search.vectorhighlight}} package so that it has access to
> the fields in {{FieldPhraseList}} and its inner class {{WeightedPhraseInfo}}.
> It seems that in recent releases, getters were added for fields in many other
> classes in {{vectorhighlight}}, and I think it makes sense to add them for
> fields in {{FieldPhraseList}} as well to support such custom implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
