[
https://issues.apache.org/jira/browse/LUCENE-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128299#comment-13128299
]
Michael McCandless commented on LUCENE-3520:
--------------------------------------------
bq. hmm, however the signature of openIfChanged(IR, boolean) actually referes
to openIfChanged(IndexReader oldReader, boolean readonly) which seems confusing
when you pass applyDeletes to it, no?
Ugh, you're right!
In fact we don't need to pass applyDeletes either; this too is inherited from
the prior reader. So I'll just reduce it to IR.openIfChanged(oldReader). Hmm
then we can simplify SearcherManager some. I'll work out a new patch.
> If the NRT reader hasn't changed then IndexReader.openIfChanged should return
> null
> ----------------------------------------------------------------------------------
>
> Key: LUCENE-3520
> URL: https://issues.apache.org/jira/browse/LUCENE-3520
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3520.patch
>
>
> I hit a failure in TestSearcherManager (NOTE: doesn't always fail):
> {noformat}
> ant test -Dtestcase=TestSearcherManager -Dtestmethod=testSearcherManager
> -Dtests.seed=459ac99a4256789c:-29b8a7f52497c3b4:145ae632ae9e1ecf
> {noformat}
> It was tripping the assert inside SearcherLifetimeManager.record,
> because two different IndexSearcher instances had different IR
> instances sharing the same version. This was happening because
> IW.getReader always returns a new reader even when there are no
> changes. I think we should fix that...
> Separately I found a deadlock in
> TestSearcherManager.testIntermediateClose, if the test gets
> SerialMergeScheduler and needs to merge during the second commit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
